Registers package with the sunpy packaging #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyclingNinja
force-pushed
the
register_template
branch
3 times, most recently
from
8c22e5c to
1d17d58
Compare
CyclingNinja
force-pushed
the
register_template
branch
from
1d17d58 to
b2f0b82
Compare
samaloney
reviewed
Oct 31, 2024
There was a problem hiding this comment.
I guess need to add 'technik' to the spell check list of words
There was a problem hiding this comment.
I can do that here, dw
samaloney
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Should probably skip anything update /**/data/ or anything not a .py file?
There was a problem hiding this comment.
yeah excellent call, i'm assuming this is broken for a test?
CyclingNinja
force-pushed
the
register_template
branch
from
2b79784 to
027967d
Compare
|
@samaloney the error on the py312 build related to the polarization check on the ilofar search, i think its as simple as if len(pol) == 1:
pol = pol[0].upper()
mask = mask & query_response["Polarisation"] == polbut I wanted to check |
|
Yea that should work 👍 I'm now questioning if that code even makes sense but that's another issue altogether |
nabobalis
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.