Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly unintended behaviour #1

Open
jmg049 opened this issue Sep 10, 2024 · 1 comment
Open

Possibly unintended behaviour #1

jmg049 opened this issue Sep 10, 2024 · 1 comment

Comments

@jmg049
Copy link

jmg049 commented Sep 10, 2024

Hi,

I was going through the code base and noticed some potentially unintended behaviour during the training of the MOSEI models. Please see the following lines of code . The if statement sets the set_name "trn" to "train" and then further down in the __init__ method and the __getitem__ method the if conditions check for whether or not the set_name is "trn" and not "train" resulting in the validation and tests blocks being run every time.

@jmg049 jmg049 closed this as completed Sep 10, 2024
@jmg049 jmg049 reopened this Sep 10, 2024
@jmg049
Copy link
Author

jmg049 commented Sep 10, 2024

It doesn't impact the __getitem__ condition but it does impact the creation of the missing index in the __init__ method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant