The annotation currently being edited is now clearly identifiable #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from upstream
|
This fixes #1996 |
|
I've realised, after reading #3590, that this change makes deleting an annotation annoying, so I will fix that first. |
kjk
reviewed
Sep 16, 2023
| @@ -1535,26 +1548,40 @@ Annotation* EngineMupdfCreateAnnotation(EngineBase* engine, AnnotationType typ, | |||
|
|
|||
| pdf_update_annot(ctx, annot); | |||
| auto res = MakeAnnotationPdf(epdf, annot, pageNo); | |||
|
|
|||
| std::optional <PdfColor> col; | |||
There was a problem hiding this comment.
We don't use std:: if we can avoid it. It causes terrible bloat of executables.
Set to ColorUnset instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing annotations it's now each to tell which piece of text is related to the comment.
A couple of notes:
EditAnnotations::StartEditAnnotationswas simply because I was offended by the repetition of calls toSetColor:-)EditAnnotations::SelectAnnotationInEditWindowhas a new call toRepaintAsync, which smells a bit to me. There might be a better way to achieve the same goal, but I don't know it.This change fixes another issue I raised in issue 3638