Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP new asset pipeline #70

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP new asset pipeline #70

wants to merge 1 commit into from

Conversation

marlo-longley
Copy link
Contributor

@marlo-longley marlo-longley commented Oct 3, 2024

Alrighty this works but def still a WIP and absolutely breaks older versions of the app usage
This also badly breaks tests.
Next steps is to fix all this but wanted to preserve the work online.

Major changes:

  • use propshaft and importmaps
  • use Blacklight 8
  • Add a package.json file within the generator template directory so that we could get leaflet, blacklight-frontend, and bootstrap JS directly from NPM
  • vendorize and basically adopt the leaflet-sidebar-rails js and styles and stop using the gem (was https://github.com/mejackreed/leaflet-sidebar-rails)
  • turn the leaflet-sidebar-rails sass into css
  • make minor inline edits to other vendor js (well, actually the only cases were adding let before a variable assignment) -- a mix of old and new JS syntax that should probably be looked at more deeply
  • convert the blacklight_heatmaps sass into css (was only 10 lines)
  • reorganize blacklight_heatmaps JS
  • set up a fake stimulus controller to test that setup
  • Delete an application.html.erb file from blacklight_heatmaps that I don't think did anything
  • Delete generator template files from blacklight_heatmaps that I don't think did anything
  • add a weird/bad _head.html.erb file so that we can include css and vendor js that does not extend leaflet's L

working with this code in a generated test app....
Screenshot 2024-10-03 at 6 00 12 PM
Screenshot 2024-10-03 at 6 00 00 PM

@@ -0,0 +1,8 @@
import { Controller } from "@hotwired/stimulus"

export default class extends Controller {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably delete this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants