Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alrighty this works but def still a WIP and absolutely breaks older versions of the app usage
This also badly breaks tests.
Next steps is to fix all this but wanted to preserve the work online.
Major changes:
leaflet-sidebar-rails
js and styles and stop using the gem (was https://github.com/mejackreed/leaflet-sidebar-rails)let
before a variable assignment) -- a mix of old and new JS syntax that should probably be looked at more deeply_head.html.erb
file so that we can include css and vendor js that does not extend leaflet'sL
working with this code in a generated test app....