Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements to the download modal #44

Open
snydman opened this issue Nov 13, 2017 · 8 comments
Open

UI improvements to the download modal #44

snydman opened this issue Nov 13, 2017 · 8 comments

Comments

@snydman
Copy link

snydman commented Nov 13, 2017

Proposal for enhancement to download modal:

image

@mialondon
Copy link

@snydman would it work the same in two-page viewing mode? And should it include 'download current view', which is handy for cropping images without opening an extra app

@mialondon
Copy link

And FWIW I think including download sizes is handy, especially as full-sized PDFs can be sizeable.

@snydman
Copy link
Author

snydman commented Nov 14, 2017

@mialondon - as for two-page viewing mode, i'll defer to our designer @jvine to answer. I expect it would be very similar, but would need to include options for each facing page to be clear. As for "download current view" I believe this is what "zoomed region" is, no? Unless you are asking a different question?

@jvine
Copy link

jvine commented Nov 15, 2017

@mialondon For two-page mode, I was thinking something like this:

Current images: Page 1 & Page 2
Zoomed region ....
Left whole image ...
Right whole image ...

@mialondon
Copy link

I think 'zoomed region' isn't the most intuitive language, which is probably why I missed it at the time, assuming I wasn't just looking for the 'current view' language. Perhaps 'image as shown'?

@jvine would there be an option for both images, or are the left/right options check boxes rather than radio buttons?

@jvine
Copy link

jvine commented Dec 6, 2017

@mialondon I'm not crazy about "zoomed region" either, but hadn't come up with a concise alternative. Maybe "current view" will work better!

There are no radio buttons or check boxes; each item in the list is a direct download link. So clicking "left image" would download the left image; "right" would download the right - as opposed to selecting one or both via checkbox and then triggering the download as a separate "submit" action. With the link interaction, I'm not sure that adding an option for "both" makes sense - the overhead of an even longer list of options to save a single click... unless that is really THE primary action when someone is looking at 2 images? I don't have enough info on that.

@mejackreed
Copy link

FWIW I don't think we will have download sizes for the images. I'm unsure of the other types of files.

@mialondon
Copy link

@jvine I hadn't realised they were direct links, so 'both' isn't necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants