Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution box should disappear after user interaction with viewer #4

Open
ggeisler opened this issue Jul 17, 2017 · 3 comments
Open

Comments

@ggeisler
Copy link

Although the attribution box is not a modal (it doesn't prevent interaction with the rest of the viewer) it does require an action to dismiss. And depending on how much is going on in the viewer, it seems fairly likely the user will want to dismiss it in many cases to make room for viewing the object of interest.

Although automatically dismissing it raises the possibility that the user will not have noticed it before it is automatically dismissed, it seems like this is an acceptable tradeoff for not forcing the user to manually dismiss it whenever using the viewer. Especially if we repeat the attribution text in the Information box/section.

Ideally, then, the attribution box should be shown when loading the viewer (as it does now) but when the user mouse clicks in the viewer, or navigates by keyboard to a viewer element, the attribution box should be closed for the user.

@tomcrane
Copy link

tomcrane commented Nov 8, 2017

I agree with the behaviour, but think it should be configurable for publishers who feel strongly about http://iiif.io/api/presentation/2.1/#attribution -

Text that must be shown when the resource it is associated with is displayed or used.

I think you can disable attribution completely, for the scenario where you're embedding the UV on your catalogue page and feel that the containing page does the job of attribution just fine.

@edsilv
Copy link
Collaborator

edsilv commented Nov 14, 2017

So we could add an extra attributionManualDismissEnabled boolean config option? It could be true by default. If false, it hides the close button and the panel disappears on interaction? This would satisfy those who want to ensure that the attribution has been acknowledged.

There's an attributionEnabled option for seadragonCenterPanel. However, this would mean it doesn't appear when embedded in an iframe on external sites.

The UV is aware of whether it's in an iframe however. We could potentially add another config option called attributionOnlyVisibleInIFrame. So if enabled, it would only appear when embedded.

@ggeisler
Copy link
Author

@tomcrane's concern that my original suggestion for the behavior should be configurable for implementors who do want the attribution to be shown makes sense to me.

And @edsilv's suggestion for how that configuration might be done also sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants