Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user location UI display #40

Open
mr-islam opened this issue Mar 13, 2021 · 2 comments
Open

Improve user location UI display #40

mr-islam opened this issue Mar 13, 2021 · 2 comments

Comments

@mr-islam
Copy link
Collaborator

Progressive feature where advanced users can access it

Might allow clicking on location name / coordinates (if geocode failed) to open the relevant location on google maps (using a simple url thing. The benefit of this is that the user can visually confirm that the detected location is accurate, more than just the city name. (though maybe a more detailed label in Layl could help too!)

The tooltip can also mention that clicking the location will open it on a map.

@mr-islam
Copy link
Collaborator Author

A more detailed location label on Layl is a bad idea, because people are used to prayer times on a city level, and any greater precision can be

  1. misleading, if there sensor is slightly off and the wrong area is identified
  2. scary for privacy

so just city, country is good -- and exposing coordinates for power users

@mr-islam
Copy link
Collaborator Author

mr-islam commented Apr 4, 2021

Opening google maps on click is not good, because that's too easy to do accidentally. Instead, only apply it to the coordinates wherever they appear (whether on the tooltip from hovering on the geocoded location name, or directly when geocode fails and the co-ordinates are displayed directly). Make sure there's a hyperlink icon or some indication that clicking will navigate to a new page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant