Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit artifacts hit storage limitations on github runners #1565

Open
srdtrk opened this issue Sep 30, 2024 · 1 comment
Open

Circuit artifacts hit storage limitations on github runners #1565

srdtrk opened this issue Sep 30, 2024 · 1 comment
Labels
artifacts An issue or PR relating to compilation or circuit artifacts other An issue that doesn't fall into a common category rust Pull requests that update Rust code

Comments

@srdtrk
Copy link
Contributor

srdtrk commented Sep 30, 2024

Description

In the current implementation of sp1_sdk, circuit artifacts are downloaded and extracted using tar, as shown in the code here.

While this approach worked well in version 1 (where the artifacts were under 4GB), version 2 introduces larger circuit artifacts (11GB+) due to the addition of Groth16. This poses a challenge when running sp1_sdk in GitHub workflows, as the free GitHub runners run out of storage space while attempting to unzip the files, as seen in this failed workflow.

Expected Behavior

To optimize storage use and prevent this issue, only the necessary artifacts for the proof scheme being used should be installed (i.e., Plonk artifacts for Plonk proofs and Groth16 artifacts for Groth16 proofs).

Version

v2.0.0+

@srdtrk
Copy link
Contributor Author

srdtrk commented Oct 2, 2024

I've verified that this is the issue by constructing my own circuit artifacts (with groth16 deleted), storing them with git-lfs as to not clutter the repo's git history. We'll be using this as a temporary solution.

@nhtyy nhtyy added rust Pull requests that update Rust code other An issue that doesn't fall into a common category artifacts An issue or PR relating to compilation or circuit artifacts labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifacts An issue or PR relating to compilation or circuit artifacts other An issue that doesn't fall into a common category rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants