-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move program and script to a shared workspace #11
Comments
@srdtrk did you get it to work? When i removed the
this is a deadlock. (will get stuck indefinitely) I suspect that: when ^^ this is probably why they have to be in their own separate workspaces. but it's a bit annoying. |
I have a repo where I did more complex stuff, all in the same workspace. I actually don't like using |
Added in #24! |
Currently, the
program
andscript
are maintained in separate workspaces. This separation has led to code duplication, such as the Solidity definition ofPublicValuesTuple
which is defined both in the script (here) and in the program (here).While this is a minor example of code duplication, the impact could be more significant in larger projects. To address this, I propose extending the workspace to include both
program
,script
, and maybe even a shared types package. This would facilitate better project structure and eliminate redundant code.While there are other solutions, such as locally importing a shared crate, I don't think this approach is considered best practice. Combining the workspaces could provide a cleaner, more maintainable solution.
I am willing to try open a PR to implement this change if there is agreement on this approach.
The text was updated successfully, but these errors were encountered: