From cfb3d4eaa2e74f223df59112300289c621b1c466 Mon Sep 17 00:00:00 2001 From: ratankaliani Date: Tue, 17 Sep 2024 00:28:49 +0000 Subject: [PATCH] add todo --- scripts/prove/bin/cost_estimator.rs | 3 ++- utils/host/src/fetcher.rs | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/prove/bin/cost_estimator.rs b/scripts/prove/bin/cost_estimator.rs index bacf66b3..3a0cfa58 100644 --- a/scripts/prove/bin/cost_estimator.rs +++ b/scripts/prove/bin/cost_estimator.rs @@ -117,7 +117,8 @@ struct BatchHostCli { } fn get_max_span_batch_range_size(chain_id: u64) -> u64 { - const DEFAULT_SIZE: u64 = 50; + // TODO: The default size/batch size should be dynamic based on the L2 chain. Specifically, look at the gas used across the block range (should be fast to compute) and then set the batch size accordingly. + const DEFAULT_SIZE: u64 = 1000; match chain_id { 8453 => 5, // Base 11155111 => 20, // OP Sepolia diff --git a/utils/host/src/fetcher.rs b/utils/host/src/fetcher.rs index 2b7a8bd1..1ee611dd 100644 --- a/utils/host/src/fetcher.rs +++ b/utils/host/src/fetcher.rs @@ -26,6 +26,7 @@ use crate::{ #[derive(Clone)] /// The OPSuccinctDataFetcher struct is used to fetch the L2 output data and L2 claim data for a /// given block number. It is used to generate the boot info for the native host program. +/// TODO: Add retries for all requests (3 retries). pub struct OPSuccinctDataFetcher { pub l1_rpc: String, pub l1_provider: Arc>>,