Add localization

[paulzakin]

No description provided.

[paulzakin]

Closed pending user action

[parnoldx]

Great app! Would be nice to have a German localization. I am happy to translate if you tell me what to do.

[paulzakin]

Thanks for the interest! Unfortunately, I decided localization is out of the scope of the app for now. If that changes I’ll be sure to reopen this issue.

[parnoldx]

Understand. The UI is fine for me. Its more about the foods. Is there a possibility to edit the basic foods and give them local names? Then I just change it for me

[paulzakin]

Huh! That’s an interesting idea. Let me think about that. I would have to think of a way to do it but I think it is feasible.

[paulzakin]

https://github.com/successible/cleanslate/blob/main/src/basicFoods.json

Ok, let's try this! I willing to try to add this gradually. All the basic foods are defined in that file. I added the locale. See line 16 to 17. I used the German (de) language code and I set the key:value property with Google Translate as an example. You can set any key:value pair and the app (in theory, once I code it in) should use it. We are going to have to discuss like interface and stuff later, but let us start with the basics. You can submit a pull request for updates to the basicFoods.json and we can go from there. Let me know if you have questions. I would only do name and maybe(?) countName if you wanted too. The reset are reused values, like categories and TBSP.

[parnoldx]

Cool, thank you! I will translate the file this weekend and will open a PR

[paulzakin]

Sounds good!

[paulzakin]

Merged your PR. Now time to discuss behavior.
Let’s start with search. How do you envision this look like?

[parnoldx]

Nice, maybe I don't understand your question but when type in "Karto" then Kartoffel (Potato) should be found

[paulzakin]

Right but should there be like a mode in Settingd to turn on - say German? And if you search for English for the word as well, should it turn up? Curious on your thoughts.

[paulzakin]

I am inclined to just keep everything in English and if a word matches in a foreign language to just have that name and the countName in the interface change and then I guess in the log as well.

[parnoldx]

Ah I see, I think mostly this would be fine if also english food matches but there are foods that are named identical/almost similar like
Zucchini = Zucchini, then both entries would be shown? That's seems confusing for the user what entry he should choose then.

[paulzakin]

I will have to play around with it - but that’s a good point. I will work on it this weekend

[paulzakin]

Hey @parnoldx just wanted to let you know I didn’t forget about this but I have been super busy recently. Not sure when I’ll get around to it but just wanted to let you know.

[parnoldx]

Thank you for letting me know.