-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expert mode, add presets (and maybe hide some parameters) #83
Comments
I am not a big fan of hiding stuff from the user to be honest. But yeah, technically we could add a category field to the settings and then arrange them in an accordion or something similar. About presets I have been thinking too, but I abandoned that Idea because I thought the setups and needs are so different that you can't really easily wrap them into a preset (or there would be so many presets, that it gets overwhelming quickly - that's the main reason why I added the hints, hoping they give enough information for the user to decide on their own). But technically this would not be too big of a deal to implement. Presets would also need to be maintained on a per layout basis - increasing the maintenance and testing work. For example: I don't have an X-Class, so who is going to test that preset? I don't want to offer presets of which I am not confident that they will work. I would much rather prefer notes or hints:
|
We have some 12s X-class and X8 drones, and various type of big motors. I come up this requests for several reasons:
|
Lemme elaborate my thoughts about "RACE", "Freestyle" presets. Only change the motor timing, PWM frequency setting, startup power to a relatively robust setting.
And leave the motor-specific parameters - KV, poles - out to let users set them manually at their own. |
I wanted to add settings categories to Bluejay configurator but never got around to it because I have been delaying all UI related changes. So for now the settings are only grouped in my notes. 😅 I think presets might be difficult to get right, but only changing some parameters could be a good idea. But maybe it isn't so useful for Bluejay because there aren't so many settings to tune? In any case, I would let someone more skilled than me define the presets 😉 |
Same. Would be cool if we could get @spatzengr on board to provide some defaults. I trust him the most when it comes to tuning... And yeah, categories are quickly implemented. |
Maybe I made some way too aggressive suggestions, I can see there are also a lot of ppl don't like hiding settings. Maybe add more tabs to organize settings better? |
I can see how it makes sense to add Categorization - but I would like to hear from the firmware maintainers how they would like to categorize it, since they know their features best. AM32 has a lot of settings that are relevant for RC cars, so I could see how this could be moved in its own section. For Bluejay/BlHeli I could only see two categories right now:
But without knowing in Detail how @mathiasvr and @AlkaMotors have envisioned their settings to be nested, it makes little sense for me to implement anything. Eg.: Would a flat hierarchy be enough
or would nestings like so make sense:
Should those categories have any other fields, like for example collapsible/collapsed/open... Also I think, the less clicks the user has to make, the better - that's why I am hesitant with accordions and such. I do understand that it would make sense on mobile though. |
I think it's possible to divide the bluejay settings into more categories, but I would prefer a flat hierarchy. |
If a flat hierarchy is enough, then basically both variants can be supported. Each group/category would have a title and a matching description: Basic settingsNo risk of destroying anything, feel free to play around here.
Intermediate settingsYou should at least somewhat understand what you are doing.
Advanced settingsIf you don't know what you are doing, you will set your house on fire.
Intermediate and advance could then also have the collapsed property. So Basci would always be visible and the other two you would need to expand to make adjustments. |
Drone modeGeneral
Advanced
Calibration
Car modeCalibration
Advanced
What do you think? @AlkaMotors |
I am no UI expert. When it comes to how things are organized in the config tools that's up to you guys. |
I am picking up this issues since it seems to start to make sense for some AM32 settings:
Both of those settings might damage your ESCs if you are not sure what you are doing. Until expert settings are implemented, I will refrain from adding those AM32 settings (also see #249, #271). |
I'm thinking about AM32.
In general, I think settings like Sinusoidal Startup, complementary PWM, stuck protection, stall protection etc.. and maybe more settings should be set to invisible to general users. We should keep settings seems SIMPLE to general users. And when they wanna to change those settings, they should be in a level with not that bad understanding of what those parameters do in ESC firmware.
I'm also think add some preset button, for "RACE", "Freestyle", "Default", "X-Class" etc.. Maybe only those 4 are enough.
Also, @AlkaMotors ,those servo settings, once they applied then the drone settings will be overwrite right? How about add a checkbox or button to organize those servo/RC car settings?
Maybe this can also be applied on Bluejay? @mathiasvr what do you think?
The text was updated successfully, but these errors were encountered: