Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-wordpress is deprecated #280

Open
jayhill90 opened this issue Jul 23, 2019 · 2 comments
Open

eslint-config-wordpress is deprecated #280

jayhill90 opened this issue Jul 23, 2019 · 2 comments
Labels

Comments

@jayhill90
Copy link

Describe the bug
eslint-config-wordpress has been deprecated in favor of the official core packages @wordpress/eslint-plugin or @wordpress/scripts

To reproduce
Steps to reproduce the behavior:

  1. Open package.json
  2. Go to the NPM page for eslint-config-wordpress https://www.npmjs.com/package/eslint-config-wordpress
  3. There's a deprecated notice.

Expected behavior
We should use the official Core configurations when possible.

Screenshots
N/A

System information (please complete)

  • OS X
  • Browser Chrome
  • Version Latest

Additional context

I was just cruising through the package.json to see what all was included by default and looking up what each pacakge does and noticed the deprecated message for eslint-config-wordpress

@jayhill90 jayhill90 added the bug label Jul 23, 2019
@jayhill90
Copy link
Author

FWIW I switched to @wordpress/scripts and got a message:

+ @wordpress/[email protected]
added 1354 packages from 713 contributors and audited 890144 packages in 78.885s
found 13000 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

So I'm not sure how we'd want to handle that, but it's all a dev dependency so maybe it's not as severe as NPM says?

@nickcernis
Copy link
Collaborator

We're using @wordpress/scripts in Genesis now and I'd be happy to use it in Sample too.

The WP core team periodically runs npm audit fix to fix those warnings, and they're dev dependencies too as you say, so I'm happy to continue down this path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants