Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore all layouts, remove or add option to disable fixed header #182

Open
nickcernis opened this issue Jan 17, 2019 · 1 comment
Open

Comments

@nickcernis
Copy link
Collaborator

nickcernis commented Jan 17, 2019

If Genesis Sample is intended as a reference theme that other developers can use as a starting point for their own themes, I think it should:

  • Showcase all features Genesis offers, including other layouts. (There's no CSS for the double-sidebar layouts at the moment, so unless they're going to be removed in a future version of Genesis, developers have to add that CSS themselves to support the extra sidebar.)
  • Remove the sticky menu or provide an option for a non-sticky menu.

That way developers can strip what they don't want, instead of having to craft code for features Genesis supports that Sample has left out.

It also sets us up better for #142, where a custom starter theme will be able to be generated from chosen features.

This is something that's echoed by the Genesis community. From Slack:

BP [9 hours ago]
I would have liked a different approach to the sample theme myself but that's a whole different rabbit hole.

LA [9 hours ago]
In what way?

LA [9 hours ago]
I’ve been messing around with it trying to figure out the best way to setup a new starter theme

LA [9 hours ago]
It’s at a hard stage right now because of the transition into all the planned features

BP [9 hours ago]
I think my favorite was version 2.3. Menus in traditional locations. No fixed header. Displayed menu below header, Layouts not removed, etc. I think the sample theme should be simple but still show all basic features that parent theme provides. Just my opinion. (edited)

LA [9 hours ago]
That’s a good point. I’ve had quite a few customers say the same thing.

@artmaug
Copy link

artmaug commented Feb 4, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants