Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add a FacetsManager #32

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Mar 28, 2024

Added

  • Add a FacetsManager to easily filter content with pre_get_posts (#32)
  • Add a facets_get('key') Twig function to easily get the value of a facets filter from the query string (#32)

Fixed

  • Fix dependency conflict (#32)

@titouanmathis titouanmathis force-pushed the feature/facets-manager branch from 6fda996 to 5784a09 Compare March 28, 2024 13:45
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.97%. Comparing base (b7cb597) to head (5784a09).

Files Patch % Lines
src/Managers/FacetsManager.php 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     62.81%   64.97%   +2.15%     
- Complexity      194      209      +15     
============================================
  Files            14       15       +1     
  Lines           554      591      +37     
============================================
+ Hits            348      384      +36     
- Misses          206      207       +1     
Flag Coverage Δ
unittests 64.97% <97.29%> (+2.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titouanmathis titouanmathis changed the base branch from master to develop March 28, 2024 13:47
@titouanmathis titouanmathis merged commit 406916c into develop Mar 28, 2024
11 checks passed
@titouanmathis titouanmathis mentioned this pull request Mar 28, 2024
@titouanmathis titouanmathis deleted the feature/facets-manager branch April 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant