Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MapboxCluster): add props to customize ids #105

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tmlmt
Copy link
Contributor

@tmlmt tmlmt commented Apr 23, 2023

Linked issue

Closes #104

Description

  • Add two new props to MapboxCluster in order to override the default naming of id:
    • idPrefix to override the default mb-cluster-${index} incremental prefix
    • divId to override the default mb-cluster-${index} incremental encapsulating <div> id
  • Updates doc accordingly. I chose to demo those new props in the middle example, MapboxClusterWithPopupDemo, to demonstrate the fact that this cluster gets its customized ids while the one before and after are set with mb-cluster-1 and mb-cluster-2

@netlify
Copy link

netlify bot commented Apr 23, 2023

👷 Deploy request for vue-mapbox-gl pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff6e212

@tmlmt
Copy link
Contributor Author

tmlmt commented Sep 29, 2023

Hey @titouanmathis, could you have a look at this and consider adding it to the next release? Thanks !

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for vue-mapbox-gl-demo canceled.

Name Link
🔨 Latest commit ff6e212
🔍 Latest deploy log https://app.netlify.com/sites/vue-mapbox-gl-demo/deploys/65202f9cdae09b000843242b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapboxCluster: ids of layer and source
1 participant