Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Sheet input validation incorrectly marks account numbers as invalid. #1770

Closed
timleyden opened this issue Nov 7, 2024 · 4 comments
Closed

Comments

@timleyden
Copy link

Describe the bug
After moving from elements hosted on a web page to the react native sdk with payment sheet we got several reports that stripe was not allowing users to enter bank account numbers. After investigation we found that several banks in Australia have 6 digit account numbers. When a customer enters this valid number they cannot proceed and receive a validation error stating the number in incomplete

To Reproduce
Steps to reproduce the behavior:

  1. Go to payment sheet with payment method type becs enabled
  2. Click on 'AU BECS Direct Debit'
  3. Scroll down to 'Account Number' and enter only 6 digits
  4. See error

Expected behavior
except 6 digit account numbers
alternatively automatically padding with 0s but this may lead to confusion

Screenshots
image

Smartphone (please complete the following information):

  • Device: Samsung s22
  • OS: Android 14
  • Version: stripe/stripe-react-native": "^0.39.0",

Additional context
Add any other context about the problem here.

@seanzhang-stripe
Copy link
Collaborator

seanzhang-stripe commented Nov 8, 2024

Hi @timleyden Thanks for flagging this problem.

The account number validation logic is from the underlying Stripe Android SDK. I've already informed the Stripe mobile SDK team about this problem. Once this problem is fixed in the new Android and iOS SDK, you can just remove yarn.lock file and run yarn install again to download the latest mobile SDK.

@samer-stripe
Copy link
Contributor

Hey @timleyden! This was fixed in this PR and released in v21.0.1. Please re-open if you continue having issues.

@karl007253
Copy link

karl007253 commented Nov 15, 2024

Hello @samer-stripe and @seanzhang-stripe! I believe we should still open this issue cause it is still happening on iOS.

image

@timleyden
Copy link
Author

@samer-stripe i don't seem to be able to reopen

@timleyden timleyden changed the title Payment Sheet input validation incorrectly marks account numbers as invalid Payment Sheet input validation incorrectly marks account numbers as invalid. Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants