Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accented letters make errors #12

Open
francoisromain opened this issue Jun 27, 2018 · 17 comments
Open

accented letters make errors #12

francoisromain opened this issue Jun 27, 2018 · 17 comments

Comments

@francoisromain
Copy link

Hello and thank you for this useful extension.

I installed the french dictionnary and set "cSpell.language": "en,fr" in the preferences.

It works fine but creates an error when a character is not accentuated in a french word. for exemple: prénom does not make an error, but prenom does. This is a good thing for a regular dictionnary, but not for code. In code, it is a common thing to use french words without accents.

Is there a way to fix that?

thank you

@Mangatt
Copy link

Mangatt commented Oct 30, 2018

I agree, this is cumberstone for multiple languages. It would be great to have option to accept words without accents.

@francoisromain francoisromain changed the title accntuated letters make errors accented letters make errors Oct 31, 2018
@Jason3S
Copy link
Collaborator

Jason3S commented Jan 13, 2020

Support for this is currently in progress.

@maiconsaraiva
Copy link

In Brazilial Portuguese we have this problem too. Waiting for update to support non-acentued words, thank you.

@robertotcestari
Copy link

Was this solved?

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 24, 2021

It is currently in progress.

Three things need to happen.

  1. The spell checker needs to be updated to use cspell@5 (In Progress)
  2. The Brazilian dictionary needs to be rebuilt. (Not yet started)
  3. This extension needs to be updated with the new Brazilian dictionary (Not yet started)

@izacsc
Copy link

izacsc commented Jun 29, 2021

Any updates on this?

@miquelbonastredreivip
Copy link

From @Jason3S list, point number 1 seems fixed in alpha version:

streetsidesoftware/vscode-spell-checker#942
streetsidesoftware/vscode-spell-checker@e4c2479

So it follows that:

  • It needs to mature and reach vscode marketplace
  • Dictionaries need to be updated

👍

@Jason3S
Copy link
Collaborator

Jason3S commented Sep 16, 2021

I'm slowing rebuilding the dictionaries.

Done so far:

  • pt_BR
  • ru
  • de_DE
  • sv_SE
  • es_ES

Up next are French and Dutch.

Are there any preferences?

@natenho
Copy link

natenho commented Mar 16, 2022

It would be a nice feature, I've just give up using pt_BR dictionary because of this, @Jason3S is it possible to release the dictionaries that are ready to go and build the remaining in new issues (e.g. per dictionary)?

@Jason3S
Copy link
Collaborator

Jason3S commented Mar 18, 2022

@natenho,

They have already been released. See Spell check ignore accentuation. · Issue #1060 · streetsidesoftware/cspell

@natenho
Copy link

natenho commented Mar 18, 2022

@Jason3S

I tried to use the settings described and I could not get it working...here is the json settings:

 "cSpell.language": "en,pt-BR",
    "cSpell.languageSettings": [
        {
            "locale": "pt",
            "languageId": "*",
            "caseSensitive": false,
        },
        {
            "locale": "pt",
            "languageId": [
                "markdown",
                "json",
                "yaml"
            ],
            "caseSensitive": true
        }
    ]

But the accented words are still being marked as mispelled.

image

@Jason3S
Copy link
Collaborator

Jason3S commented Mar 18, 2022

@natenho,

The locales have to be the same or it won't match. pt is not the same as pt-BR.

If you set locale to be pt,pt-BR, it mean match against either pt or pt-BR.

Please try:

    "cSpell.languageSettings": [
        {
            "locale": "pt,pt-BR",
            "languageId": "*",
            "caseSensitive": false,
        },
        {
            "locale": "pt,pt-BR",
            "languageId": [
                "markdown",
                "json",
                "yaml"
            ],
            "caseSensitive": true
        }
    ]

@natenho
Copy link

natenho commented Mar 18, 2022

ok, now it works! thank you very much!!

I thought locale was a "contains" match, like stated in your post here:

image

@Jason3S
Copy link
Collaborator

Jason3S commented Mar 18, 2022

I can see how that is misleading.

@EwenQuim
Copy link

EwenQuim commented May 2, 2022

Up next are French and Dutch.

Can you please add the french version? This extension seems really great but is currently unusable in French because of the amount of accented words. Thank you for your work!

@Jason3S
Copy link
Collaborator

Jason3S commented May 3, 2022

@EwenQuim,

Thank you for the reminder. It has been published.

@ar-std
Copy link

ar-std commented Jun 13, 2022

Hi @Jason3S,

thank you for all your effort! May I ask you to have a look at the German dictionary, too?

To achieve utf8 compliance it is common in German to substitute umlauts:

  • Ä -> Ae
  • Ö -> Oe
  • Ü -> Ue
  • ä -> ae
  • ö -> oe
  • ü -> ue

Currently my solution is to add all words I encounter to a custom dictionary, but it would be great to have these substitutions build-in.

Cheers,
Arne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants