Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: margin and padding logical props #1685

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Feat: margin and padding logical props #1685

merged 4 commits into from
Apr 18, 2024

Conversation

madhurisandbhor
Copy link
Contributor

What does it do?

Mapping margin and padding internally to equivalent logical props.

Why is it needed?

To support direction and writing modes in DS

How to test it?

You can check logical properties story added for demo purpose(to be improved/updated in RTL feat) where on inspect you can see all margin and padding properties are converted to equivalent logical properties.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b3ebefc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 11:02am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 11:02am

@madhurisandbhor madhurisandbhor changed the title Feature: margin and padding logical props Feat: margin and padding logical props Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

Size Change: +63 B (0%)

Total Size: 504 kB

Filename Size Change
packages/strapi-design-system/dist/index.js 195 kB +28 B (0%)
packages/strapi-design-system/dist/index.mjs 194 kB +35 B (0%)
ℹ️ View Unchanged
Filename Size
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB
packages/strapi-icons/dist/index.js 41.2 kB
packages/strapi-icons/dist/index.mjs 41 kB

compressed-size-action

@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
@madhurisandbhor madhurisandbhor self-assigned this Apr 15, 2024
@madhurisandbhor madhurisandbhor added pr: feature This PR adds a new feature source: design-system relates to design-system package labels Apr 15, 2024
@madhurisandbhor madhurisandbhor force-pushed the feat/logical-css-props branch from fee047c to 78662ac Compare April 16, 2024 10:48
@madhurisandbhor madhurisandbhor requested a review from remidej April 16, 2024 10:55
@madhurisandbhor madhurisandbhor marked this pull request as ready for review April 16, 2024 11:02
joshuaellis
joshuaellis suggested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lets take this opportunity to make better typography docs since we should be able to support RTL text.

What do you think of Nasa's typography folder? https://nasa-jpl.github.io/explorer-1/?path=/docs/foundation-typography--fonts Interested to hear if you've found any that you really like :)

@madhurisandbhor
Copy link
Contributor Author

@joshuaellis I did check few design systems for typography folder and I agree we should definitely improve ours. Adobe spectrum also looks good, but Nasa's more simpler like we have with storybooks.
But why don't we do it as a separate PR or with RTL?

@madhurisandbhor
Copy link
Contributor Author

https://canvas.workday.com/tokens/type is interesting too

@madhurisandbhor madhurisandbhor merged commit 49fe7e6 into releases/2.0.0 Apr 18, 2024
10 checks passed
@madhurisandbhor madhurisandbhor deleted the feat/logical-css-props branch April 18, 2024 10:25
joshuaellis pushed a commit that referenced this pull request Apr 18, 2024
@madhurisandbhor @joshuaellis
feat: margin and padding logical props (#1685)
732330a
This was linked to issues May 7, 2024
[bug]: Checkbox missing padding in RTL #1714
Closed
[feat]: RTL support #1308
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@remidej remidej Awaiting requested review from remidej

Assignees

@madhurisandbhor madhurisandbhor

Labels
pr: feature This PR adds a new feature source: design-system relates to design-system package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat]: RTL support [bug]: Checkbox missing padding in RTL
2 participants
@madhurisandbhor @joshuaellis