Discount code ignored

[ipokkel]

Describe the bug

When a discount code is applied at checkout where the level has payment plans the discount code cost settings is not applied to the level cost, order, and email data. The payment plan selected at checkout overrides the discount code cost settings.

To Reproduce
Steps to reproduce the behavior:

1. Create a level with at least 1 payment plan.
2. Create a discount code for this level and apply the discount code on the checkout page.
3. See that the discount code updated level cost text is displayed but does not rewrites any payment level cost text in the payment plans section.
4. Complete checkout and submit.
5. Confirm on confirmation page, checkout notification email, and order created that the selected payment plan costs was applied instead of the discount code.

Isolating the problem (mark completed items with an [x]):

• I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
• This bug happens with a default WordPress theme active, or Memberlite.
• I can reproduce this bug consistently using the steps above.

[ipokkel]

A possible temporary workaround to consider is to remove payment plans from the checkout page when a discount code is applied.

https://gist.github.com/ipokkel/c42c5a8a092e18556e64bb59976d5b8b

[dwanjuki]

Another customer ran into similar issues. (Mods: 515592)
Here's a workaround for when the discount code is passed in via the URL:

https://gist.github.com/dwanjuki/1b4f095bf486f1424a98fa1971b05484

[kimcoleman]

We do not want to support a discount code that works on each payment plan.

The code should always override the level price, just as it does without the Payment Plans Add On. We should always use the level ID's discount code pricing as set in the code.

If there is a discount code applied, either via URL or applied on the checkout page directly, we should hide the payment plans section of the checkout page (use JS to set to hidden on "apply code" or when page renders, hide automatically). The gists here are good starting point for what we will build into this Add On.