uplink-sys(build): Fix cross-compilation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GodTamIt
force-pushed
the
fix-cross-compile
branch
7 times, most recently
from
fa8dcbf to
59d5a08
Compare
|
This can't be landed yet because I'm not using the correct release/upgrade process for However, we can see our new cross-compile CI check works wonderfully. |
GodTamIt
force-pushed
the
fix-cross-compile
branch
from
59d5a08 to
6563ac9
Compare
This fixes cross-compilation by setting the Go `GOOS` and `GOARCH` flags for `uplink-c`.
GodTamIt
force-pushed
the
fix-cross-compile
branch
from
6563ac9 to
a02074e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cross-compilation by setting the Go
GOOSandGOARCHflags foruplink-c.This change, combined with storj/uplink-c#30, will allow Rust targets to cross-compile successfully.
Additionally, this change includes a new CI workflow to ensure some form of cross-compilation works.
Fixes #87