Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why the comment was not posted for #71 #72

Open
tuliren opened this issue Dec 15, 2022 · 3 comments
Open

Investigate why the comment was not posted for #71 #72

tuliren opened this issue Dec 15, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@tuliren
Copy link
Member

tuliren commented Dec 15, 2022

@tuliren tuliren added the bug Something isn't working label Dec 15, 2022
@tuliren tuliren mentioned this issue Dec 15, 2022
@jrhizor
Copy link
Contributor

jrhizor commented Dec 15, 2022

Yeah it's just because it's for a fork.

Maybe we should allow manually triggering for a whitelisted commit on a fork somehow? The build was triggered when you reviewed, right? Those aren't differentiated in our db vs non-fork PRs, but that's probably fine since it's approved?

@tuliren
Copy link
Member Author

tuliren commented Dec 15, 2022

The build was triggered when you reviewed, right?

Yes, I approved the action on that PR, and the action did run. It's probably a permission issue from the GITHUB_TOKEN.

@jrhizor
Copy link
Contributor

jrhizor commented Dec 15, 2022

All of the GITHUB_TOKEN-related auth in the action run looks like it worked properly, it's the webhook that wasn't triggered or allowed (not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants