Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortLinkStatus constants appear to be the wrong type #318

Closed
gnuoy opened this issue Apr 29, 2024 · 1 comment · Fixed by #319
Closed

PortLinkStatus constants appear to be the wrong type #318

gnuoy opened this issue Apr 29, 2024 · 1 comment · Fixed by #319

Comments

@gnuoy
Copy link
Contributor

gnuoy commented Apr 29, 2024

The port link status constants are of type LinkStatus rather that PortLinkStatus *1. This seems to be a mistake as Port.LinkStatus is of type PortLinkStatus *2

*1 https://github.com/stmcginnis/gofish/blob/main/redfish/port.go#L143
*2 https://github.com/stmcginnis/gofish/blob/main/redfish/port.go#L723
@gnuoy
Copy link
Contributor Author

gnuoy commented Apr 29, 2024

#319

@gnuoy gnuoy mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type of PortLinkStatus constants gnuoy/gofish
1 participant
@gnuoy