Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART Tx/Rx Pin Swap #2538

Open
fronders opened this issue Oct 28, 2024 · 1 comment · May be fixed by #2601
Open

UART Tx/Rx Pin Swap #2538

fronders opened this issue Oct 28, 2024 · 1 comment · May be fixed by #2601
Labels
enhancement New feature or request

Comments

@fronders
Copy link

I'm working on implementing Rx/Tx pin swap functionality (mentioned in #1418) for a project at the moment, thought I'd open a PR when I'm done.

I have a question about which option you guys prefer:

  • have a dedicated pin swap enable method for user to explicitly select i.e. smth like void setPinSwap(bool enabled);. This means user would have to call it before begin(), with Rx and Tx pins specified unswapped in constructor or setRx() and setTx()
  • automatically enable pin swap if Tx pin is found in the Rx pin map and vice versa

I personally prefer the second one that would just let the user select needed Rx Tx pins wanted and if MCU supports it things would just work.
What do you think?

@fronders fronders added the enhancement New feature or request label Oct 28, 2024
@fpistm
Copy link
Member

fpistm commented Oct 28, 2024

Hi @fronders
I agree second one seems good option.

fronders added a commit to atmosphericiq/Arduino_Core_STM32 that referenced this issue Nov 5, 2024
@fronders fronders linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants