Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling error dma_circualr_mode() #143

Open
dauntown opened this issue Jan 15, 2024 · 2 comments
Open

Spelling error dma_circualr_mode() #143

dauntown opened this issue Jan 15, 2024 · 2 comments

Comments

@dauntown
Copy link

pub trait DmaMode<ADC> {
    /// Error type returned by ADC methods
    type Error;
    fn dma_enable(&mut self, enable: bool);
    fn dma_circualr_mode(&mut self, enable: bool);   // <=======
}

Here DmaMode contains the method dma_circualr_mode(). Please correct it to dma_circular_mode(). The name error doesn't inspire confidence it will in fact work.

As seen on https://github.com/stm32-rs/stm32g0xx-hal/blob/e6145ef83c639e736556fb4775f349aef7100ad6/src/analog/adc.rs#L374C16-L374C16

@dauntown dauntown changed the title Spelling error Spelling error dma_circualr_mode() Jan 15, 2024
@Disasm
Copy link
Member

Disasm commented Jan 15, 2024

Thanks! Would you like to create a PR to fix the typo?

@dauntown
Copy link
Author

dauntown commented Jan 15, 2024

No thanks, the honor, and the breaking change, is all yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants