Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jstreer.js #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ismirsehregal
Copy link

Again using changed.jstree event instead of select_node.jstree and deselect_node.jstree to fix #34

The fix for #16 is not affected

update shiny input on changed.jstree event
@stla
Copy link
Owner

stla commented Jul 17, 2024

Hi @ismirsehregal

Did you identify the reason for which I commented out the line? Because I don't want to restore this line if I don't know this reason.

@ismirsehregal
Copy link
Author

ismirsehregal commented Jul 17, 2024

Hi Stéphane, it seems you haven't actually commented it out. The (commented) line was added with this commit (triggered by this issue) (see the diff - nothing was deleted. Maybe it was just for testing and you haven't noticed any difference?).

However, if you rather want to keep using the select_node.jstree and deselect_node.jstree events instead of changed.jstree, we could add listeners for select_all.jstree / deselect_all.jstree as an alternative solution. Although, I haven't noticed any issue using changed.jstree and it seems to be the recommended way as it covers all cases.

@ismirsehregal
Copy link
Author

Hi Stéphane, have you had the chance to test this? Cheers

@stla
Copy link
Owner

stla commented Jul 29, 2024

My main laptop is dead. Now I only have an old one (with Windows 7) and I don't like to work on this one. But I will.

@ismirsehregal
Copy link
Author

Okay - thanks for the update! Please let me know if there is anything I can do to help. Cheers

@stla
Copy link
Owner

stla commented Aug 2, 2024

Yes you can ;-) Tell me whether there's a nice IDE for R that works with Windows 7. I really miss RStudio.

@ismirsehregal
Copy link
Author

Uh 🙈... that's bad.

Maybe you can downgrade:
https://forum.posit.co/t/what-is-the-latest-rstudio-version-for-windows-7/152152

..or once I installed RStudio Server on a Raspberry Pi 😅

@ismirsehregal
Copy link
Author

ismirsehregal commented Sep 11, 2024

Hi Stéphane, I just wanted to leave a frindly reminder, that it would be really helpful if this is merged (or the alternative approach mentioned above is implemented).

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changed.jstree event is not captured
2 participants