Skip to content

Latest commit

 

History

History
8 lines (7 loc) · 871 Bytes

ios-review-guidelines.md

File metadata and controls

8 lines (7 loc) · 871 Bytes
Raw

Review Guidelines

  1. All targets must be able to build an IPA. To check this go to your app on your CI (e.g. Bitrise) click the big green button on the upper right called Start/Schedule Build, enter your branch name, select MATRIXTestDeploy from the workflow list and start it. It will build all app targets, runs the tests and builds the app. If all that works the chances are very high that your PR is able to be build by the CI without errors.
  2. The coding guidelines must match.
  3. Code duplicates are not allowed.
  4. If you found a typo, copy the sentence, paste it in the Github comment and mark the typo using bold font. This makes it easier for the reviewer to find them if is e.g. a single word.

Links