incusd/instance/qemu/qmp: Don't risk blocking QMP on eject

This would lead to occasional QMP dead locks when the instance would be queried while processing the eject request. Signed-off-by: Stéphane Graber <[email protected]>
stgraber · Jan 29, 2024 · add5702 · add5702
1 parent 017e426
commit add5702
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/internal/server/instance/drivers/qmp/monitor.go b/internal/server/instance/drivers/qmp/monitor.go
@@ -109,10 +109,12 @@ func (m *Monitor) start() error {
 				if e.Event == EventDiskEjected {
 					id, ok := e.Data["id"].(string)
 					if ok {
-						err = m.Eject(id)
-						if err != nil {
-							logger.Warnf("Unable to eject media %q: %v", id, err)
-						}
+						go func() {
+							err = m.Eject(id)
+							if err != nil {
+								logger.Warnf("Unable to eject media %q: %v", id, err)
+							}
+						}()
 					}
 				}