Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition image with other scale type #32

Open
nastutusha opened this issue Jan 10, 2020 · 2 comments · May be fixed by #33
Open

Transition image with other scale type #32

nastutusha opened this issue Jan 10, 2020 · 2 comments · May be fixed by #33
Assignees
@troy379
Labels
bug Something isn't working

Comments

@nastutusha
Copy link

nastutusha commented Jan 10, 2020 •
edited
Loading

Describe the bug
If an imageview that is used in WithTranstionFrom has other scale type than ImageViewer's the transition isn't smooth.

To Reproduce
Steps to reproduce the behavior:

  1. Add imageView with hard-coded height/width and scaleType "centerCrop"
  2. Load image there and show full screen with StfalconImageViewer using that image view in WithTransitionFrom

Expected behavior
Smooth transition

Video with the bug
https://www.dropbox.com/s/27evomzehu12d1j/sample.mov?dl=0

Additional context
It could be an android transition bug, though maybe you know how to workaround or fix as you definitely have an expertise for it.
@nastutusha nastutusha added the bug Something isn't working label Jan 10, 2020
@nastutusha nastutusha linked a pull request Jan 28, 2020 that will close this issue
Open
@rasitayaz
Copy link

Is this bug fixed? How can we achieve smoother transitions?

@MHPtweidinger
Copy link

it'd really be a great improvement to have this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troy379 troy379

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make smooth animation of different image scale type Diversido/StfalconImageViewer
4 participants
@nastutusha @troy379 @MHPtweidinger @rasitayaz