Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for POST. #3

Open
GoodClover opened this issue Jun 29, 2019 · 2 comments
Open

Remove support for POST. #3

GoodClover opened this issue Jun 29, 2019 · 2 comments

Comments

@GoodClover
Copy link

Line 38 of server.js
You are allowing the POST method to be used when this is deprecated in the coffee protocol.
Quote https://tools.ietf.org/html/rfc2324:

A coffee pot server MUST accept both the BREW and POST method
equivalently. However, the use of POST for causing actions to happen
is deprecated.

You should probably give a warning saying this is deprecated if used.
@GoodClover
Copy link
Author

Also thought I'd mention in package.json your requiring express when that doesn't seem to be used.

@cybertelx
Copy link

cybertelx commented Aug 21, 2019 •
edited
Loading

A coffee pot server MUST accept both the BREW and POST method
equivalently. However, the use of POST for causing actions to happen
is deprecated.
They must accept both, so your main point is invalid
EDIT: Yeah they should probably make a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cybertelx @GoodClover