Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow change GAC artifact_id if project.name doesn't match artifact basename #43

Open
childnode opened this issue Jul 16, 2018 · 0 comments

Comments

@childnode
Copy link

childnode commented Jul 16, 2018

https://github.com/stempler/gradle-versioneye-plugin/blob/master/src/main/groovy/org/standardout/gradle/plugin/versioneye/PomTask.groovy#L150

is fixed to project.name which is a bad idea for submoduled projects, since it might be duplicate in different projects where artifacts baseName is set differently (refer to Tar.baseName or or Jar.baseName both feeded by project.archivesBaseName

even the current solution is only manageable in projects without submodules where rootProject.name can be set in gradle.settings, but any subsequent module's project.name is hard set in gradle.settings (pathname by convention) and not manageable by project.name in subproject's build.gradle (read only prop)

so: please use project.archivesBaseName as artifact_id in PomTask! else you have to hack s.th. like

./gradlew -q :${app}:versioneye-pom;
mv ${app}/build/pom.json{,.bak};
prjname="<what you set up for project.archivesBaseName>"
jq ".artifact_id=\"${prjname}\"" ${app}/build/pom.json.bak > ${app}/build/pom.json;
jq '.artifact_id' ${app}/build/pom.json;
./gradlew :${app}:versionEyeCreate -x :${app}:versioneye-pom;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant