Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getEvents docs #275

Open
psheth9 opened this issue Aug 24, 2024 · 2 comments
Open

Update getEvents docs #275

psheth9 opened this issue Aug 24, 2024 · 2 comments

Comments

@psheth9
Copy link
Contributor

psheth9 commented Aug 24, 2024

Update getEvents doc based on #230

  • Add EndLedger in GetEventsRequest. This provides finer control and clarity on the range of ledgers being queried.
  • This change enhances the scalability and can now support a larger retention window (~7 days) for events.
  • Ledger Scanning Limitation: The getEvents RPC will now scan a maximum of 10,000 ledgers per request. This limits the resource usage and ensures more predictable performance, especially for queries spanning large ledger ranges.
@mollykarcher
Copy link
Contributor

This change enhances the scalability and can now support a larger retention window (~7 days) for events.

Maybe we defer this change until p22, since @aditya1702 is planning on testing up to 7 days at a later time

@aditya1702
Copy link
Contributor

aditya1702 commented Oct 30, 2024

I think this will need to wait since we are not releasing all the breaking changes in P22 now (due to the SDK backward compatibility issues).

cc @Shaptic @mollykarcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants