Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban getting started guide broken #1138

Open
leighmcculloch opened this issue Dec 16, 2024 · 3 comments · May be fixed by #1162
Open

soroban getting started guide broken #1138

leighmcculloch opened this issue Dec 16, 2024 · 3 comments · May be fixed by #1162
Assignees
@janewang
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Dec 16, 2024 •
edited
Loading

The main getting started guide for Soroban/Stellar contracts appears to be broken:
https://developers.stellar.org/docs/build/smart-contracts/getting-started/storing-data

The guide proposes to perform:

stellar contract init ./ --with-example increment

However, the --with-example option was deprecated and removed from the CLI.

cc @stellar/devx
@leighmcculloch leighmcculloch added the bug Something isn't working label Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Ideas in Dev Docs Dec 16, 2024
@leighmcculloch
Copy link
Member Author

The guide needs updating to use:

stellar contract init . --name increment

And then instruct the user to copy the code in.

@janewang janewang moved this from Ideas to To Do in Dev Docs Dec 17, 2024
@janewang janewang self-assigned this Jan 6, 2025
@janewang janewang moved this from To Do to In Progress in Dev Docs Jan 6, 2025
janewang added a commit that referenced this issue Jan 6, 2025
@janewang
Update cli command in getting started guide and closes #1138
7f181f2
@janewang janewang moved this from In Progress to In Review in Dev Docs Jan 6, 2025
@briwylde08 briwylde08 mentioned this issue Jan 7, 2025
Open
@github-project-automation github-project-automation bot moved this from In Review to Done in Dev Docs Jan 7, 2025
@janewang janewang reopened this Jan 7, 2025
@janewang
Copy link
Contributor

janewang commented Jan 7, 2025

Will close after merging #1035

@chadoh
Copy link
Contributor

chadoh commented Jan 8, 2025

This is a more comprehensive fix: #1121

@ElliotFriend ElliotFriend linked a pull request Jan 8, 2025 that will close this issue
Update cli command in getting started guide and closes #1138 #1162
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janewang janewang

Labels
bug Something isn't working
Projects
Dev Docs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cli command in getting started guide and closes #1138 stellar/stellar-docs
5 participants
@chadoh @leighmcculloch @janewang @briwylde08 and others