Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The automatic polyfill fails when both 'window' and 'global' exist. #340

Open
RudeySH opened this issue Jan 2, 2019 · 0 comments
Open
Labels

Comments

@RudeySH
Copy link

RudeySH commented Jan 2, 2019

I just had some trouble with the polyfill. I'm building a browser app which has a global variable named global. This caused the polyfill to add the Promise object to my global object, instead of adding it to window. The opposite could also happen: building a Node app that has a variable named window.

Not sure if this should be fixed, though. I reckon it was probably a bad idea by me to have a global variable anyway. I renamed it to something else so I can continue to use this polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants