-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Use current block - 3 reference for broadcast tx #13
Comments
Guys could you explain why this change was introduced? I'm often getting an errors while making transactions. I'm on golos blockchain and I'm using a forked version of steem-python. Here is the my report to golos-python: I reverted this change and errors disappeared. |
This might explain a recent bug in yo too
…On Nov 10, 2017 10:43 AM, "Vladimir Kamarzin" ***@***.***> wrote:
Guys could you explain why this change was introduced? I'm often getting
an errors while making transactions. I'm on golos blockchain and I'm using
a forked version of steem-python.
Here is the my report to golos-python:
GolosChain#3 <GolosChain#3>
I reverted this change and errors disappeared.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqWaJmNeDRZ2R77dWbk9pN9nXpy_FIZks5s1CjNgaJpZM4N1QXK>
.
|
Is this issue still relevant? |
Yes, it is likely still relevant. If the change is introducing problems then it's likely a bug in the change, not the concept. Each tx needs to refer to the block hash of a recent block. A block from a few blocks ago should be used, instead of the absolute tip of the chain, in the event of a microfork that invalidates the tip block which then renders the transactions that referenced it invalid. |
@sneak I think reasonable default is use last_irreversible_block as a reference. This will prevent transactions loosing at chain forks. |
That’s fine too. |
todo: https://github.com/steemit/steem-js/pull/161/files
The text was updated successfully, but these errors were encountered: