Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use current block - 3 reference for broadcast tx #13

Open
Netherdrake opened this issue Jun 9, 2017 · 6 comments
Open

Feature: Use current block - 3 reference for broadcast tx #13

Netherdrake opened this issue Jun 9, 2017 · 6 comments

Comments

@Netherdrake
Copy link
Contributor

todo: https://github.com/steemit/steem-js/pull/161/files

pharesim added a commit to pharesim/steem-python that referenced this issue Jun 23, 2017
pharesim added a commit to pharesim/steem-python that referenced this issue Jun 23, 2017
GwenNelson added a commit that referenced this issue Aug 20, 2017
* Issue #13 - use head_block - 3 as reference

* Issue #13 - use head_block - 3 as reference
@bitphage
Copy link
Contributor

Guys could you explain why this change was introduced? I'm often getting an errors while making transactions. I'm on golos blockchain and I'm using a forked version of steem-python.

Here is the my report to golos-python:
GolosChain#3

I reverted this change and errors disappeared.

@GwenNelson
Copy link
Contributor

GwenNelson commented Nov 10, 2017 via email

@cyon1c
Copy link
Contributor

cyon1c commented Mar 6, 2018

@sneak
@john-g-g

Is this issue still relevant?

steem-python does not currently implement this.

@sneak
Copy link
Contributor

sneak commented Apr 3, 2018

Yes, it is likely still relevant. If the change is introducing problems then it's likely a bug in the change, not the concept.

Each tx needs to refer to the block hash of a recent block. A block from a few blocks ago should be used, instead of the absolute tip of the chain, in the event of a microfork that invalidates the tip block which then renders the transactions that referenced it invalid.

@bitphage
Copy link
Contributor

bitphage commented Apr 3, 2018

@sneak I think reasonable default is use last_irreversible_block as a reference. This will prevent transactions loosing at chain forks.

@sneak
Copy link
Contributor

sneak commented Apr 3, 2018

That’s fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants