Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivariate Normal/Inverse-Wishart distribution #90

Open
akonneker opened this issue Oct 2, 2018 · 8 comments · May be fixed by #170
Open

Multivariate Normal/Inverse-Wishart distribution #90

akonneker opened this issue Oct 2, 2018 · 8 comments · May be fixed by #170

Comments

@akonneker
Copy link

Do you have any plans to implement the distributions in the title? I'm working on implementing some things from Simon Prince's Computer Vision, and those are the only two of the common conjugate-pair distributions he uses that aren't already implemented in statrs, as far as I can tell.

@boxtown
Copy link
Collaborator

boxtown commented Oct 2, 2018

There were definitely plans to implement both, I just haven't had a lot of time recently. I can see if I can get one of the two into master by the end of this week and maybe the other next week. As always, I 100% welcome anyone who wishes to contribute

@akonneker
Copy link
Author

akonneker commented Oct 2, 2018 via email

@boxtown
Copy link
Collaborator

boxtown commented Nov 22, 2018

After doing some investigating, this will take a little more work than I initially thought, mainly in that currently statrs provides no support for matrices / linear algebra. It is clear that the better choice would be to depend on one of the already existing libraries out there for working with matrices, but the question is which one to use. I'll need to take some time to properly evaluate the current landscape as I want to be very judicious about adding dependencies

@akonneker
Copy link
Author

Thank you for looking into this. I've been pretty slammed at work, so I didn't make much progress on my end. Nalgebra seems like the most likely candidate to me re:matrix support, but that seems like a fairly hefty dependency to add, so I can understand your caution.

My impression was that things in the rust linear algebra space were somewhat in limbo until const generics dropped, but the last time I looked into it was at least a year ago. Nalgebra seems to have made nice progress since then, and the other libraries seem to have gone dormant.

@vks
Copy link
Contributor

vks commented Nov 23, 2018

My impression was that things in the rust linear algebra space were somewhat in limbo until const generics dropped

AFAIK, const generics are still not implemented: rust-lang/rust#44580

@boxtown
Copy link
Collaborator

boxtown commented Nov 26, 2018

It looks like Nalgrebra seems to be the best maintained/most popular library, I'll experiment with incorporating it as a dependency in order to implement one of these distributions and report back. Hopefully it doesn't take me a month this time

@vks
Copy link
Contributor

vks commented Jul 6, 2021

The multivariate normal distribution was implemented by now, using nalgebra. The inverse Wishart distribution still needs to be implemented.

@henryjac
Copy link
Contributor

Inverse Wishart (and Wishart) was implemented in #170

@YeungOnion YeungOnion linked a pull request Sep 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants