[4.x] Make tags with old __call methods macroable by using wildcard method instead. #9553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead. Add events to mutate the collections tag before and after fetching entries.
sylvesterdamgaard
changed the title
jasonvarga
requested changes
Feb 21, 2024
Ok. Removed the events from this PR. I will make a separate one with the events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make tags with the old __call methods macroable by using wildcard method instead.
Fix issue with $this not being available inside of macroables due to wrong namespace check.
Adding events to hook into the collections tag on Fetching Entries and Fetched Entries.
This allows to mutate to params before fetching and allows to mutate or register the output before returning the entries.