[5.x] Fallback to nocache content when request is missing the Cache middleware
#9406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddleware-is-missing
jasonvarga
requested changes
Jan 26, 2024
There was a problem hiding this comment.
The failing test that's happening now would have happened before too if you ran it by itself.
Since you had a static property, its value sticks around between tests.
So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.
Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.
…ddleware-is-missing
…e-content-when-cache-middleware-is-missing
duncanmcclean
changed the title
nocache content when request is missing the Cache middlewarenocache content when request is missing the Cache middleware
…ddleware-is-missing
…ddleware-is-missing
Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.
jasonvarga
deleted the
fix/fallback-to-nocache-content-when-cache-middleware-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
{{ nocache }}tag on custom routes that aren't using Statamic'sCachemiddleware, used for static caching.Previously, if you used the
{{ nocache }}tag or it's Blade directive counterpart on a custom route without the middleware,NOCACHE_PLACEHOLDERtext will have been displayed.This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.
Fixes #6744.