Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Match whereJsonContains to how Laravel handles it #11113

Closed
wants to merge 38 commits into from
Closed

[6.x] Match whereJsonContains to how Laravel handles it #11113

wants to merge 38 commits into from

Conversation

ryanmitchell
Copy link
Contributor

This PR updates our stache whereJsonContains (etc) implementation to match every item in the values, not any as it currently does. This brings it inline with the behaviour on the Laravel side.

This is however a breaking change so I think targeting 6.x and master is right for this (?).

The current behaviour is comparable to whereJsonOverlaps, which I've opened a seperate PR for: #11112

daun and others added 30 commits October 28, 2024 15:29
@daun
[5.x] Allow setting tag pair content from fluent tags (statamic#11018)
b75055b
@daun
[5.x] Add support for avif image format (statamic#11016)
f8c6108
@irfandumanx @jasonvarga
[5.x] Fix helpBlock error with custom js validation rule (statamic#11023
7172e7a 
)

Co-authored-by: Jason Varga <[email protected]>
@jackmcdade
[5.x] Fix color fieldtype's collapsed state showing plain HTML (stata…
0cd579a 
…mic#11031)

Fix color fieldtype's collapsed state showing plain HTML

Closes statamic#10991
@godismyjudge95
[5.x] Fix Filesystem AbstractAdapter put method return (statamic#11032)
b8f73b5
@JohnathonKoster @jasonvarga
[5.x] Statamic Tag Blade Compiler (statamic#10967)
4ecdd9b 
Co-authored-by: Jason Varga <[email protected]>
@jasonvarga
changelog
3bd3171
@jacksleight
[5.x] Fix inline Bard with leading line break (statamic#11038)
f74cd05
@ryanmitchell @jasonvarga
[5.x] Add a config for specifying the default layout (statamic#11025)
ce21344 
Co-authored-by: Jason Varga <[email protected]>
@jasonvarga
[5.x] Translations (statamic#11050)
37c7c2b
@duncanmcclean
[5.x] Fix query parameters in external script URLs being wrongly enco…
b9ea442 
…ded (statamic#11052)
@jasonvarga
[5.x] Improved fieldtype search using keywords (statamic#11053)
495a3d9
@morhi
[5.x] Fix addon events dispatched twice if registered manually (stata…
ba04ca4 
…mic#11049)
@duncanmcclean
[5.x] Files Fieldtype: Don't truncate existing filename (statamic#11055)
2a63aef
@daun
[5.x] Fix typeahead relationship input corrupting data (statamic#11059)
44ea6dc
@jasonvarga
[5.x] Offer to enable Pro during make user command (statamic#11071)
ee9d9ee
@jasonvarga
[5.x] Fix Ignition Runnable Error Solutions (statamic#11072)
89fab65
@duncanmcclean
[5.x] Update addon .gitignore stub (statamic#11068)
d8d09d1
@duncanmcclean
[5.x] Integer fields should render with type="number" (statamic#11065)
ad32277
@jasonvarga
[5.x] Adjust legacy ignition classes (statamic#11073)
f012812
@jesseleite
[5.x] Add --clear option for starter-kit:export (statamic#11079)
16bb315
@jasonvarga
[5.x] Extra values for entry field conditions, including depth (stata…
9b4302c 
…mic#11080)
@jasonvarga
changelog
44c8bab
@ryanmitchell
[5.x] Use layout config in errors too (statamic#11083)
90e8488
@jasonvarga
[5.x] Render HTML for dictionary fields in listings (statamic#11088)
97bdb43
@duncanmcclean
[5.x] Fix error after deleting role when storing users in the database (
0a2ec25 
statamic#11069)
@ebeauchamps
[5.x] French translations (statamic#11093)
31fe562
@aaronbushnell @jasonvarga
[5.x] Create edit/{id} route for control panel access (statamic#11092)
c6727f3 
Co-authored-by: Jason Varga <[email protected]>
@duncanmcclean
[5.x] Add fullyQualifiedHandle method to Blueprint (statamic#11096)
1d78ccf
@duncanmcclean
[5.x] Add "Container" option to Asset Folders fieldtype (statamic#11099)
09a2c4b
@ryanmitchell ryanmitchell changed the title [6.x] Match how whereJsonContains to how Laravel handles it [6.x] Match whereJsonContains to how Laravel handles it Nov 12, 2024
@jasonvarga
Copy link
Member

Can you please re-open (or rebase appropriately) so that only the appropriate changes are in this PR? I've brought master up to date.

@jasonvarga jasonvarga closed this Nov 12, 2024
@ryanmitchell ryanmitchell mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.