Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Ensure updating references gets all global variables #11186

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Nov 28, 2024

This PR updates the logic in the GetsItemsContainingData trait to return the global set localizations values() rather than a keyed collection.

Without this change it was only returning one variables for each localization, as the flatMap was using the localization's key.

Closes #11177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving an image doesn't update refs on all globals
1 participant