[5.x] Prevent comma completing tags when defining container validation rules #11132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks but I think the actual solution should be to bring the validation ux over from the field settings. The use of a taggable fieldtype here was just a quick fix. The validation field could be extracted to a fieldtype and then used in both places. |
duncanmcclean
deleted the
prevent-comma-completing-tag-when-defining-container-validation-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the Taggable fieldtype when it's used for defining an asset container's validation rules, where a comma in a rule completes the tag, which can be frustrating in the context of validation rules.
Fixes #11122.