3.3 Query data retrieval performance issue?

[johncarter-]

I am building a csv of some entry data. Back in 3.2 it took ~20ms per entry, in 3.3 its now taking ~120ms per entry.

I know there were some DX improvements with auto augmenting entry properties but this seems to have added a bit of overhead.

I'm wondering if someone could help me get back the speed from 3.2

// Make an array of all products
$products = Entry::query()
    ->where('collection', 'products')
    ->where('published', true)
    ->where('hidden', false)
    ->where('discontinued', false)
    ->where('price', '>', '1')
    ->limit(2)
    ->get();

$transformedProducts = [];

foreach ($products as $product) {
    ray()->measure($product->sku);

    // ⌚ 3.2.*: 20ms ⚡
    // ⌚ 3.3.3: 120ms 🐢
    $oldway = [
         'id' => $product->sku,
         'title' => $product->title,
         'description' => $product->augmentedValue('range')->value()->get('description') ?? $product->augmentedValue('range')->value()->get('short_description') ?? 'No description available',
         'availability' => 'in stock', // in stock
         'condition' => 'new',
         'price' => $product->augmentedValue('range')->value()->price . ' GBP', // 54.99 GBP
         'link' => $product->augmentedValue('permalink'), //
         'image_link' => $product->augmentedValue('images')->value()->first()?->absoluteUrl() ?? '',
         'brand' => $product->augmentedValue('product_brand')->value()?->get('title') ?? 'No brand',
    ];

    // ⌚ 3.3.3: 215ms 🐢🐢
    $newWay = [
        'id' => $product->sku,
        'title' => $product->title,
        'description' => $product->range->description ?? $product->range->short_description ?? 'No description available',
        'availability' => 'in stock', // in stock
        'condition' => 'new',
        'price' => $product->range->price . ' GBP', // 54.99 GBP
        'link' => $product->permalink, //
        'image_link' => $product->images->first()?->absoluteUrl() ?? '',
        'brand' => $product->product_brand?->title ?? 'No brand',
    ];

    // $transformedProducts[] = [];

    ray()->measure($product->sku);
}

[edalzell]

Sounds like a bug John, can you add it?

[johncarter-]

I can, but I'm not sure how reproducible it is. 🤔

I have started migrating this site out of Statamic now, so time and motivation to raise a proper copy-pastable issue about it is pretty scarce. If I get a chance, I'll put a demo repo together.

[jasonvarga]

The properties that you were using property access for in 3.2 (id and title), try doing $product->get('id') and $product->get('title') instead. That'll avoid augmentation for those. The other lines are essentially identical in 3.3 except they're abstracted behind a magic method.

We'll look into this, though.