Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deaths time conversion factor #821

Open
daniel-klein opened this issue Dec 10, 2024 · 1 comment
Open

Deaths time conversion factor #821

daniel-klein opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working highpriority High priority for collaborators
Milestone

Comments

@daniel-klein
Copy link
Contributor

Deaths has:

if isinstance(death_rate, ss.TimePar):
    factor = self.t.dt # TODO: figure out why this isn't 1.0
else:
    factor = ss.time_ratio(unit1=self.t.unit, dt1=self.t.dt, unit2='year', dt2=1.0)

But this appears to be an error. The factor should be 1.0 as in Births if using unit-away rates, which is on this codepath.

@daniel-klein daniel-klein self-assigned this Dec 10, 2024
daniel-klein added a commit that referenced this issue Dec 10, 2024
daniel-klein added a commit that referenced this issue Dec 10, 2024
@cliffckerr cliffckerr added this to the Version 2.3 milestone Dec 11, 2024
@cliffckerr cliffckerr added the bug Something isn't working label Dec 11, 2024
@cliffckerr
Copy link
Contributor

Should add a test asserting birth and death rates

@daniel-klein daniel-klein added the highpriority High priority for collaborators label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working highpriority High priority for collaborators
Projects
None yet
Development

No branches or pull requests

2 participants