Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batcher): set use_kzg_da flag in build block input #2345

Open
wants to merge 1 commit into
base: arni/batcher/block_builder_factory/set_block_timestamp
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (arni/batcher/block_builder_factory/set_block_timestamp@3bb7ed9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/starknet_api/src/block.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                                    Coverage Diff                                    @@
##             arni/batcher/block_builder_factory/set_block_timestamp    #2345   +/-   ##
=========================================================================================
  Coverage                                                          ?   27.16%           
=========================================================================================
  Files                                                             ?      121           
  Lines                                                             ?    13932           
  Branches                                                          ?    13932           
=========================================================================================
  Hits                                                              ?     3785           
  Misses                                                            ?     9811           
  Partials                                                          ?      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_block_timestamp branch from a21cac0 to 3bb7ed9 Compare November 28, 2024 15:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from 0b1faae to ef924ab Compare November 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants