Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): set temp gas prices in propose block input #2341

Open
wants to merge 1 commit into
base: arni/batcher/propose_block/verify/block_number
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.79%. Comparing base (7fc654e) to head (6158a58).

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##           arni/batcher/propose_block/verify/block_number    #2341       +/-   ##
===================================================================================
+ Coverage                                            5.37%   17.79%   +12.42%     
===================================================================================
  Files                                                 145      119       -26     
  Lines                                               17092    13882     -3210     
  Branches                                            17092    13882     -3210     
===================================================================================
+ Hits                                                  918     2470     +1552     
+ Misses                                              16112    11141     -4971     
- Partials                                               62      271      +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/batcher/propose_block/verify/block_number branch from 7fc654e to 14db3f5 Compare December 1, 2024 12:34
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_gas_prices branch from 6158a58 to 37ca509 Compare December 1, 2024 12:39
@ArniStarkware ArniStarkware changed the title chore(batcher): set temp gas prices in propose block input chore(starknet_batcher): set temp gas prices in propose block input Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants