fix(blockifier): native can have CairoSteps mode #2272
Conversation
|
This change is |
|
Artifacts upload workflows: |
Yoni-Starkware
force-pushed
the
yoni/sierra-gas/fix-tracked-resource
branch
from
7df6ab8
to
438aebc
Compare
Yoni-Starkware
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2272 +/- ##
===========================================
+ Coverage 40.10% 68.64% +28.54%
===========================================
Files 26 108 +82
Lines 1895 13896 +12001
Branches 1895 13896 +12001
===========================================
+ Hits 760 9539 +8779
- Misses 1100 3948 +2848
- Partials 35 409 +374 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)
crates/blockifier/src/execution/contract_class.rs line 142 at r1 (raw file):
Self::V1(contract_class) => contract_class.tracked_resource(min_sierra_version), #[cfg(feature = "cairo_native")] Self::V1Native(contract_class) => {
What makes contracts be marked as Native in the first place if we have Sierra code for everything and it seems from your change it's unrelated to the Sierra version?
Code quote:
Self::V1Native(contract_class)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)
crates/blockifier/src/execution/contract_class.rs line 142 at r1 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
What makes contracts be marked as
Nativein the first place if we have Sierra code for everything and it seems from your change it's unrelated to the Sierra version?
It depends on the implementation of the state. It's not a mark, it's a different object.
We, for example, are going to hold Native classes only (state-level), but run native (and not casm) according to your config (execution-level).
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)
crates/blockifier/src/execution/contract_class.rs line 142 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
It depends on the implementation of the
state. It's not a mark, it's a different object.
We, for example, are going to hold Native classes only (state-level), but run native (and not casm) according to your config (execution-level).
I.e., run SierraGas according to your config, which will enable native.
No description provided.