Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): separate create and validate logic on gas prices #2243

Merged
merged 1 commit into from
Nov 28, 2024

chore(blockifier): separate create and validate logic on gas prices

d60ce60
Select commit
Loading
Failed to load commit list.
Merged

chore(blockifier): separate create and validate logic on gas prices #2243

chore(blockifier): separate create and validate logic on gas prices
d60ce60
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 28, 2024 in 0s

52.85% (+12.74%) compared to e3165c4

View this Pull Request on Codecov

52.85% (+12.74%) compared to e3165c4

Details

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (e3165c4) to head (d60ce60).
Report is 614 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/blockifier/block.rs 90.47% 2 Missing ⚠️
crates/starknet_batcher/src/block_builder.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2243       +/-   ##
===========================================
+ Coverage   40.10%   52.85%   +12.74%     
===========================================
  Files          26      228      +202     
  Lines        1895    25790    +23895     
  Branches     1895    25790    +23895     
===========================================
+ Hits          760    13631    +12871     
- Misses       1100    11178    +10078     
- Partials       35      981      +946     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.