Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code]: Is build/StarcoinFramework/BuildInfo.yaml necessary? #169

Open
pause125 opened this issue Sep 29, 2022 · 5 comments
Open

[Code]: Is build/StarcoinFramework/BuildInfo.yaml necessary? #169

pause125 opened this issue Sep 29, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@pause125
Copy link
Collaborator

Is the file build/StarcoinFramework/BuildInfo.yaml necessary? It will lower the develop efficiency because that once a PR is merged, all the other PRs have to rebase the main branch manually and run ./scripts/build.sh to update the file even if no conflicts in sources files.

If we remove build/StarcoinFramework/BuildInfo.yaml, then the PRs having no conflicts can be merged automaticlly.

@pause125 pause125 added the enhancement New feature or request label Sep 29, 2022
@jolestar
Copy link
Member

jolestar commented Sep 29, 2022

How about we just keep build/StarcoinFramework/docs? @WGB5445 @baichuan3 @jiangying000 @yubing744 @sanlee42

@yubing744
Copy link
Collaborator

I think Docs can also be deleted, we can generate Docs in github-ci and publish it to github-page, and provide a script in scripts to quickly generate Docs locally.

@jiangying000
Copy link
Collaborator

I think Docs can also be deleted, we can generate Docs in github-ci and publish it to github-page, and provide a script in scripts to quickly generate Docs locally.

I'd support this approach if it does not weaken corrrectness and security, since PR diffs will be more concise

@WGB5445
Copy link
Collaborator

WGB5445 commented Sep 30, 2022

I think Docs can also be deleted, we can generate Docs in github-ci and publish it to github-page, and provide a script in scripts to quickly generate Docs locally.

I also agree with this approach. There are too many submission files now. A small change needs to modify the buildfile and exp file at the same time. The build file should not exist in the warehouse.
doc should be placed under wiki
This will be more convenient if we do more optimizations to the documentation system in the future

@jolestar
Copy link
Member

Ok, let's remove the build dir from the git repo. The primary purpose of keeping the build directory was to detect bytecode changes that the Move or OS versions version changes might bring about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants