-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code]: Is build/StarcoinFramework/BuildInfo.yaml necessary? #169
Comments
How about we just keep |
I think Docs can also be deleted, we can generate Docs in github-ci and publish it to github-page, and provide a script in scripts to quickly generate Docs locally. |
I'd support this approach if it does not weaken corrrectness and security, since PR diffs will be more concise |
I also agree with this approach. There are too many submission files now. A small change needs to modify the buildfile and exp file at the same time. The build file should not exist in the warehouse. |
Ok, let's remove the build dir from the git repo. The primary purpose of keeping the build directory was to detect bytecode changes that the Move or OS versions version changes might bring about. |
Is the file
build/StarcoinFramework/BuildInfo.yaml
necessary? It will lower the develop efficiency because that once a PR is merged, all the other PRs have to rebase the main branch manually and run./scripts/build.sh
to update the file even if no conflicts insources
files.If we remove
build/StarcoinFramework/BuildInfo.yaml
, then the PRs having no conflicts can be merged automaticlly.The text was updated successfully, but these errors were encountered: