Ensure returned uri from code actions contain a scheme #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jim! Have you pointed your neovim at this to verify it works manually? |
|
yes, I updated in my neovim copy of standardrb to test it manually. I don't have vscode, so I was a little afraid of maybe breaking vscode. |
|
looking at fixing the tests now |
Using Neovim 0.10 with the ruby-lsp plugin, standard returns code actions to allow for quick fixes. They were returning the uri without the scheme, and that caused neovim to give an error. To correct for the error, I added an ensure_uri_scheme method to parse the uri and add the "file" scheme if the uri did not include one.
jimnanney
force-pushed
the
neovim-10-code-actions-uri-fix
branch
from
2c803f5 to
2fcca8d
Compare
|
I'd be extremely shocked if this broke anything so happy to merge |
|
Released as 1.39.2 If anyone has a chance to test quickfixes (command-period) on VS Code to see if it fixes it there, we should update the table in the README https://github.com/standardrb/standard?tab=readme-ov-file#language-server-protocol-support |
|
Wow, thanks for merging and releasing that so quickly! Really appreciate it! |
|
You break it, you buy it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Neovim 0.10 with the ruby-lsp plugin, standard returns code actions to allow for quick fixes. They were returning the uri without the scheme, and that caused neovim to give an error.
To correct for the error, I added an ensure_uri_scheme method to parse the uri and add the "file" scheme if the uri did not include one.
Example of the erorr:
Edit: Updated tests to use new file type uri in return.