Add support for Code Actions under Ruby LSP #636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support code actions (e.g. "Quick Fix" in VS Code), we need a more sophisticated way of invoking RuboCop than our kinda hacky stdin / stdout capture technique that invokes the CLI version. Ruby LSP provides a great way for doing this: extend the base runner and rely on instance variables of the runner to get at the actual RuboCop objects, then translate that to LSP types from the language_server_protocol gem's interfaces.
Lots of thoughts:
Standardizer
object (which the Ruby LSP addon and the built-in server both depend on) is now returning diagnostic objects, whereas the built-instandard --lsp
server is expecting JSON parsed from stdin.That needs to be translated appropriately before shipping anythingDone ✅--lsp
server in favor of pointing people to Ruby LSP and/or delegating to the RuboCop LSP